Use simple comparision instead of Contains / fix #20 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yerfinojul! I don't think there is a reason why |
tedsmitt
pushed a commit
that referenced
this pull request
Nov 1, 2022
…alue for tasks of ec2 launch type
tedsmitt
pushed a commit
that referenced
this pull request
Nov 1, 2022
…alue for tasks of ec2 launch type
tedsmitt
pushed a commit
that referenced
this pull request
Nov 12, 2022
…alue for tasks of ec2 launch type
tedsmitt
added a commit
that referenced
this pull request
Nov 21, 2022
* fix: #22 check PlatformFamily for nil value, as there is no default value for tasks of ec2 launch type * fix: #21 lookup os family when task is ec2 launch type, avoid nil pointer ref when ec2 launch type * fix: #21 add functions to determine underlying container os and set PlatformFamily to prevent nil reference * test: #21 add tests for new functions
tedsmitt
pushed a commit
that referenced
this pull request
Jan 24, 2023
…alue for tasks of ec2 launch type
tedsmitt
pushed a commit
that referenced
this pull request
Jan 24, 2023
…alue for tasks of ec2 launch type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
strings.Containsour flow breaks when selecting the container - see issue #20The problem is we have 2 containers that are named like this
I pick up the first
sample-ui, but it ends up ssh intosample-ui-logger, because.Containsfunction will match both in that case.Please check it out, not sure there is a specific reason for using
.Contains