Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectures change for Python only library #27

Merged
merged 2 commits into from
May 11, 2022

Conversation

frheault
Copy link
Collaborator

@frheault frheault commented May 11, 2022

Majors change in architecture (#24)

  • Rename to trx/
  • Deleted the zarr implementation
  • Switch from two submodules to a single one

Two installation modes (#23)

  • pip --install-option was not working, using an environment variable instead
  • Specifically for Apple's new CPU (to avoid needing Dipy)
  • Refactor the library's code to avoid importing Dipy unless necessary

Adapted tests

  • Tests are working both with the "minimal" and "full" install
  • Scripts are not tested with the "minimal" install, they are skipped

@frheault frheault requested a review from arokem May 11, 2022 18:47
@arokem
Copy link
Collaborator

arokem commented May 11, 2022

This looks good to me. We might get a tiny conflict with #13 because of this change: 0e66373, but I think we can deal with it.

@arokem arokem merged commit 1866153 into master May 11, 2022
@frheault
Copy link
Collaborator Author

There was a offsets.float32 left by mistake in the main repo.
Probably due to some pytest manipulation when my first commit failed (the test).

I am not on my computer at the moment, I will do a PR tomorrow to delete it and maybe add a bit to the README.md, and also move the specification to trx-spec.

It is shaping up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants