New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trx integration to Dipy (part 2) #59
Conversation
there is a PR for that: dipy/dipy#2715 the pyproject.toml need to be much more complex than that. it needs to allow build the project, allow It is part of the long todolist but priority high. it needs to be done before september and the release of python 3.12. DIPY will not work with python 3.12, with the current state. |
I think that we should add a CI with Windows on it, and then if that passes, we can merge that, make a release and then pin the new version as a dependency on DIPY. BTW, the documentation build failure is because of some incompatibilities in the sphinx-autoapi functionality. We figured this out on pyAFQ, and that can be resolved by pinning in the setup.cfg, as in https://github.com/yeatmanlab/pyAFQ/pull/1038/files. |
+1 👍 |
Co-authored-by: Ariel Rokem <arokem@gmail.com>
I will finish this up during MICCAI! Thanks! |
…on into trx_integration_dipy_2
1e06f57
to
4c4271f
Compare
@arokem Maybe this is not the exact error you had? I tried leaving the sphinx version and removing it and astroid == (or <=) and it is not working. Maybe I misunderstood the "fix"? |
No, I think that you are doing all the right things, but it looks like the current CI error maybe originates from my merge earlier today of #58, so please revert that change first (sorry - I should have just closed that one instead, but it's just a couple of lines, so shouldn't be hard to undo). |
Ahhh thank you, I was so focused on the few lines on this PR and I did not see that PR, I was puzzled, thank you! |
OK - great! Thanks for adding the tests on Mac and Windows. I think this is good to go, so I'll merge it. Let me know if you think we need any other folllow-up. Otherwise, we can make a release after this is merged. |
No description provided.