Skip to content

Commit

Permalink
Fix error message if no supported package manager found
Browse files Browse the repository at this point in the history
```
Unrecognized package manager.
```

Or:

```
Package manager 'foo' is not supported by 'prepare/install'.
```

when the package manager has been detected, but is not supported by
`prepare/install`.

I like this error more than:

```
'Package manager "None" is not supported.'
```

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
  • Loading branch information
thrix authored and psss committed May 3, 2024
1 parent 94eb7cf commit a94a9ad
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tmt/steps/prepare/install.py
Expand Up @@ -704,9 +704,13 @@ def go(
exclude=self.data.exclude,
guest=guest)

elif guest.facts.package_manager is None:
raise tmt.utils.PrepareError('Unrecognized package manager.')

else:
raise tmt.utils.PrepareError(
f'Package manager "{guest.facts.package_manager}" is not supported.')
f"Package manager '{guest.facts.package_manager}' "
"is not supported by 'prepare/install'.")

# Enable copr repositories...
if isinstance(installer, Copr):
Expand Down

0 comments on commit a94a9ad

Please sign in to comment.