Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make collected requires/recommends guest-aware #2010

Closed
happz opened this issue Apr 19, 2023 · 0 comments · Fixed by #2567
Closed

Make collected requires/recommends guest-aware #2010

happz opened this issue Apr 19, 2023 · 0 comments · Fixed by #2567
Assignees
Labels
Milestone

Comments

@happz
Copy link
Collaborator

happz commented Apr 19, 2023

Current: prepare checks all steps, phases, and tests, collects all their requirements, and adds a phase to install them on all guests.
Better: prepare installs requirements only on guests where they are needed, i.e. instead of a single phase across all guests, possibly multiple targetted phases would be created.

Imagine a prepare step for a specific role of guests that enables a repository on said guests, without which requirements are impossible to install. Attempting to install all requirements on guests outside of this role would fail.

happz added a commit that referenced this issue Dec 13, 2023
Instead of collecting all requirements and installing them on all
guests, the `prepare` step would collect requirements for each guest
based on whether phases and tests are enabled for the given guest. This
will result in more phases installing requirements, but guests won't be
polluted by packages never needed by tests - or `prepare` or `finish`
phases - running on them.

Fixes #2010.
@happz happz self-assigned this Dec 14, 2023
@happz happz added this to the 1.31 milestone Dec 14, 2023
happz added a commit that referenced this issue Dec 14, 2023
Instead of collecting all requirements and installing them on all
guests, the `prepare` step would collect requirements for each guest
based on whether phases and tests are enabled for the given guest. This
will result in more phases installing requirements, but guests won't be
polluted by packages never needed by tests - or `prepare` or `finish`
phases - running on them.

Fixes #2010.
happz added a commit that referenced this issue Jan 2, 2024
Instead of collecting all requirements and installing them on all
guests, the `prepare` step would collect requirements for each guest
based on whether phases and tests are enabled for the given guest. This
will result in more phases installing requirements, but guests won't be
polluted by packages never needed by tests - or `prepare` or `finish`
phases - running on them.

Fixes #2010.
happz added a commit that referenced this issue Jan 3, 2024
Instead of collecting all requirements and installing them on all
guests, the `prepare` step would collect requirements for each guest
based on whether phases and tests are enabled for the given guest. This
will result in more phases installing requirements, but guests won't be
polluted by packages never needed by tests - or `prepare` or `finish`
phases - running on them.

Fixes #2010.
happz added a commit that referenced this issue Jan 9, 2024
Instead of collecting all requirements and installing them on all
guests, the `prepare` step would collect requirements for each guest
based on whether phases and tests are enabled for the given guest. This
will result in more phases installing requirements, but guests won't be
polluted by packages never needed by tests - or `prepare` or `finish`
phases - running on them.

Fixes #2010.
@psss psss added the prepare Prepare step label Jan 15, 2024
@psss psss closed this as completed in 8a816c5 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants