-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make collected requires/recommends guest-aware #2010
Comments
Closed
happz
added a commit
that referenced
this issue
Dec 13, 2023
Instead of collecting all requirements and installing them on all guests, the `prepare` step would collect requirements for each guest based on whether phases and tests are enabled for the given guest. This will result in more phases installing requirements, but guests won't be polluted by packages never needed by tests - or `prepare` or `finish` phases - running on them. Fixes #2010.
3 tasks
happz
added a commit
that referenced
this issue
Dec 14, 2023
Instead of collecting all requirements and installing them on all guests, the `prepare` step would collect requirements for each guest based on whether phases and tests are enabled for the given guest. This will result in more phases installing requirements, but guests won't be polluted by packages never needed by tests - or `prepare` or `finish` phases - running on them. Fixes #2010.
happz
added a commit
that referenced
this issue
Jan 2, 2024
Instead of collecting all requirements and installing them on all guests, the `prepare` step would collect requirements for each guest based on whether phases and tests are enabled for the given guest. This will result in more phases installing requirements, but guests won't be polluted by packages never needed by tests - or `prepare` or `finish` phases - running on them. Fixes #2010.
happz
added a commit
that referenced
this issue
Jan 3, 2024
Instead of collecting all requirements and installing them on all guests, the `prepare` step would collect requirements for each guest based on whether phases and tests are enabled for the given guest. This will result in more phases installing requirements, but guests won't be polluted by packages never needed by tests - or `prepare` or `finish` phases - running on them. Fixes #2010.
happz
added a commit
that referenced
this issue
Jan 9, 2024
Instead of collecting all requirements and installing them on all guests, the `prepare` step would collect requirements for each guest based on whether phases and tests are enabled for the given guest. This will result in more phases installing requirements, but guests won't be polluted by packages never needed by tests - or `prepare` or `finish` phases - running on them. Fixes #2010.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current:
prepare
checks all steps, phases, and tests, collects all their requirements, and adds a phase to install them on all guests.Better:
prepare
installs requirements only on guests where they are needed, i.e. instead of a single phase across all guests, possibly multiple targetted phases would be created.Imagine a
prepare
step for a specific role of guests that enables a repository on said guests, without which requirements are impossible to install. Attempting to install all requirements on guests outside of this role would fail.The text was updated successfully, but these errors were encountered: