-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMT_TREE
vs TMT_SOURCE_DIR
#2184
Comments
Source path is different depending if it's dist-git downloaded or not. Could be a design problem upstream teemtee/tmt#2184 Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Probably a design flaw upstream, but this should be a quick fix in the meantime teemtee/tmt#2184 --------- Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Test sources are always copied elsewhere (workdir//discover/<phase_name>/tests) and only in some cases you can find them within TMT_TREE location. I don't think we expose the test path directly, but To give you an example when TMT_TREE doesn't contain any test sources:
When you |
If we expose the test workdir directly (e.g. I'm afraid that depending on the directory structure is a thing how to run into problems in the future. |
Where would
For prosperity, here is the test design that I am working with that sparked this necessary design. In this case just the |
@lukaszachy Actually I tried with |
I'll take better look tomorrow. It is really possible there are more bugs here and there. |
@LecrisUT I think I understand the problem. It happens this way because there can be multiple source files and it isn't safe to merge them together (e.g what about name conflicts) so tmt extracts the tarball as-is into TMT_SOURCE_DIR. I'm looking at available variables but I don't see any nice way how to do what you need.
I guess |
in tmt we could probably export '/var/tmp/tmt/run-116/plans/examples/discover/default-0/tests' which is path to where tests are stored... not sure about the name though. |
So this is related to #2098 in some way as well. The wildcard solution should work ok, but I should work on applying the patches to source, otherwise fixing this downstream will be problematic. Anyway for this issue, should consider some other useful variables to define to make these more navigable. From the previous comment:
|
teemtee/tmt#2184 (comment) Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
teemtee/tmt#2184 (comment) Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
teemtee/tmt#2184 (comment) Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
teemtee/tmt#2184 (comment) Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
teemtee/tmt#2184 (comment) Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
I was examining this run and I've noticed something peculiar in how the design works. In my test I have:
But that does not work in upstream because it should point to
TMT_SOURCE_DIR
.But then, what's the usecase of having
TMT_TREE
not point toTMT_SOURCE_DIR
when using a plan withIf we consider other cases when using
how: fmf
withurl
or otherwise, in those cases the source is available atTMT_TREE
right? Onlydist-git
behaves differently with the downloaded tree pointing to a different location.Is there a reason for having these be different? Should the behaviour be how non-dist-git download work, or the other way around? A temporary fix is possible with
${TMT_SOURCE_DIR:-$TMT_TREE}
, but it is unexpected to have to do that.The text was updated successfully, but these errors were encountered: