Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trees are no longer pickleable #2503

Closed
t184256 opened this issue Nov 21, 2023 · 2 comments · Fixed by #2506
Closed

Trees are no longer pickleable #2503

t184256 opened this issue Nov 21, 2023 · 2 comments · Fixed by #2506
Assignees
Labels
base bug Something isn't working
Milestone

Comments

@t184256
Copy link
Contributor

t184256 commented Nov 21, 2023

TMT trees are no longer pickleable.

https://github.com/teemtee/tmt/blame/445479d64acfc70b0ef7e100a09c88233c9ec52f/tmt/log.py#L93

I'm caching a large amount of adjusted trees, now I have to remove the _logger from them to cache them.

@t184256
Copy link
Contributor Author

t184256 commented Nov 21, 2023

Both of the wrappers don't need to be local functions, one could be an identity transform, and the other could be a tmt.utils.remove_color directly, w/o wrapping.

@happz
Copy link
Collaborator

happz commented Nov 22, 2023

Interesting use case. I agree, the code can be simpler, and it might be a trivial patch, let's see whether it can be fixed quickly enough for 1.30.

@happz happz self-assigned this Nov 22, 2023
@happz happz added bug Something isn't working base labels Nov 22, 2023
@happz happz added this to the 1.30 milestone Nov 22, 2023
@psss psss changed the title TMT trees are no longer pickleable Trees are no longer pickleable Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants