Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout parameter for reboot #2525

Closed
guazhang opened this issue Nov 29, 2023 · 3 comments · Fixed by #2635
Closed

Add a timeout parameter for reboot #2525

guazhang opened this issue Nov 29, 2023 · 3 comments · Fixed by #2635
Assignees
Labels
execute Execute step reboot reboot of guests during `tmt run`
Milestone

Comments

@guazhang
Copy link

the default reboot timeout is 5min, it's not enough for heavy server.
Hit a error like below.

12:06:12 Reboot during test '/kdump/setup-nfsdump' with reboot count 1.
...
12:13:26 wait: 'check_boot_time' finished successfully but took too much time, 130.47 over quota
12:13:26 Connection to guest failed after reboot.
12:13:26 00:00:20 errr /kdump/setup-nfsdump (on s1) (reboot timeout) [1/3]

so maybe we need a var to extend the timeout, like TMT_REBOOT_TIMEOUT=600

@happz happz added execute Execute step reboot reboot of guests during `tmt run` labels Nov 29, 2023
@happz
Copy link
Collaborator

happz commented Nov 29, 2023

https://github.com/teemtee/tmt/blob/main/tmt/steps/provision/__init__.py#L1574 - it's either a timeout, extracted from a reboot request file, or the default. Tests don't bother with their custom timeouts, and why would they, and the default cannot be changed. A way to define custom default for the whole tmt run would be nice.

@rh-mcermak
Copy link
Contributor

Hypothetically it might make sense to allow customizing the timeout by hostname. Maybe it'd be overengineering, dunno.

@happz happz self-assigned this Jan 16, 2024
@happz happz added this to the 1.31 milestone Jan 16, 2024
@happz
Copy link
Collaborator

happz commented Jan 16, 2024

At the meeting it was agreed we'd:

  • add an environment variable to allow the user to change the default, and
  • bump the default value to 10 minutes.

happz added a commit that referenced this issue Jan 23, 2024
@psss psss changed the title add timeout parameter for reboot Add a timeout parameter for reboot Jan 23, 2024
psss pushed a commit that referenced this issue Jan 24, 2024
@psss psss linked a pull request Jan 24, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute Execute step reboot reboot of guests during `tmt run`
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants