-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support restart of test when it crashes #2696
Comments
Hi @happz and @lukaszachy I found a workaround for my case. By using
result:
|
Hello, @happz and @lukaszachy I wrote a test that forcibly perform a stack underflow within a kernel module, that causes a BUG and subsequent restart after configuring 5 seconds of kernel.panic with sysctl
I tried with 'rstrnt-prepare-reboot' before loading the module that causes the crash, but tmt disconnects, tries to rsync and times out. I think this one and other two tests for testing memory violation handling within the kernel are cases in favor of implementing this feature. |
@pablmart hello, could you share the test? I'd like to use it as a reproducer when working on the feature. |
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
Yes the test is on the same repo linked in the above comment mentioning 'rstrnt-prepare-reboot': |
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
I encountered a similar problem when testing ftrace= kernel parameter with tmt run. Test with auto-osbuild-qemu-rhivos9-qa-ostree-aarch64-7874633.e1769674.qcow2.xz by manual The available tracers are:
|
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
Kicking off the implementation of the actual test restart in #2870. It does have some rough edges, although there is a test that passes. I plan to run it with the kernel-stack-overflow-udnerflow-scribbling test provided by @pablmart, feel free to experiment too. One piece we need to address ASAP - naming. I picked some names for new keys, but they are ugly and I don't like them. I can change them easily, but I'm out of ideas - feel free to propose changes here as well, besides the actual bugs and issues :) |
A similar case: what if the test does not crash, but triggers a reboot, e.g. through Ansible role, unable to use
|
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
To accomodate tests that can be restarted without a reboot, e.g. after a test crash or kernel panic, tmt would keep a test restart counter. It is similar to the well-established `TMT_REBOOT_COUNT`, but tracks test restarts. For most of the tests, both counters would have the same value. Related to #2696
The MR 2870 solves the issue with the kernel-stack-overflow-underflow-scribbling test. Many thanks! |
As discussed today, there's a use case for restarting a test when it crashes:
In this case, the user would like to see the test restarted - the test was killed by a kernel oops, and when restarted, it would take care of follow-up steps, like decoding the kernel dump.
After some discussion, the proposal would be:
TMT_REBOOT_COUNT
, but counting test restarts. With reboot disabled, the test might run multiple times whileTMT_REBOOT_COUNT
remains zero.TMT_REBOOT_COUNT
#2787The text was updated successfully, but these errors were encountered: