Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create container images from the latest non-dev copr build #1751

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

lukaszachy
Copy link
Collaborator

Packit is producing y+1.dev versions however we want to have one with matching release in the container.

No idea yet how to avoid the manual 'copr build' step :/

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed on the chat, let's pick the latest tmt from Fedora stable repos instead. This will also remove the need for the manual copr build.

@psss
Copy link
Collaborator

psss commented Nov 21, 2023

Any plans with this one, @lukaszachy?

@lukaszachy
Copy link
Collaborator Author

@psss If we go by previous agreement it means one needs to remember building a new image about a week after the release.

I'll check if we didn't solve the problem by moving to hatch. Or if there isn't simpler fix.

Waiting means we will forget.

@psss
Copy link
Collaborator

psss commented Nov 21, 2023

@psss If we go by previous agreement it means one needs to remember building a new image about a week after the release.

Yeah, using updates-testing could bit a faster, but still, one has to remember to finish it.

I'll check if we didn't solve the problem by moving to hatch. Or if there isn't simpler fix.

What about installing the latest non-dev release from the copr repo? Could the exact rpm naming be used somehow?

@psss psss added this to the 1.31 milestone Nov 28, 2023
@psss psss modified the milestones: 1.31, 1.32 Jan 9, 2024
@psss
Copy link
Collaborator

psss commented Jan 24, 2024

What about installing the latest non-dev release from the copr repo? Could the exact rpm naming be used somehow?

This seems to be working as expected:

# dnf install tmt-[0-9].[0-9][0-9].[0-9]*
Last metadata expiration check: 1:51:30 ago on Wed Jan 24 10:07:14 2024.
Dependencies resolved.
==============================================================================================================================
 Package                            Arch    Version                   Repository                                         Size
==============================================================================================================================
Installing:
 tmt                                noarch  1.30.0-1.fc39             copr:copr.fedorainfracloud.org:group_teemtee:tmt  803 k

It picks the latest stable version from the copr repo even if there is a newer dev version:

# dnf install tmt
Last metadata expiration check: 1:53:06 ago on Wed Jan 24 10:07:14 2024.
Dependencies resolved.
==============================================================================================================================
 Package                         Arch   Version                        Repository                                        Size
==============================================================================================================================
Installing:
 tmt                             noarch 1.31.dev49+gdf8303f1-main.fc39 copr:copr.fedorainfracloud.org:group_teemtee:tmt 825 k

@lukaszachy, let's try it this way?

@psss psss force-pushed the lzachar-dockerfile-changes branch from b655279 to bedecb3 Compare January 24, 2024 12:23
@psss psss added documentation Improvements or additions to documentation packaging labels Jan 24, 2024
@psss psss modified the milestones: 1.32, 1.31 Jan 24, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working fine.

@psss psss removed the request for review from FrNecas January 24, 2024 12:27
@psss psss changed the title Dockerfile request matching tmt version Create container images from the latest non-dev copr build Jan 24, 2024
@lukaszachy
Copy link
Collaborator Author

@psss LGTM (I can't provide approval for (according to the github) my PR)

@psss
Copy link
Collaborator

psss commented Jan 24, 2024

@psss LGTM (I can't provide approval for (according to the github) my PR)

Good, thanks for having a look!

@psss psss force-pushed the lzachar-dockerfile-changes branch from bedecb3 to 99d5807 Compare January 24, 2024 16:12
@psss psss self-assigned this Jan 24, 2024
@psss
Copy link
Collaborator

psss commented Jan 24, 2024

/packit test -i full

Once the stable copr build is created we can move the `quay` branch to
trigger the new container images creation. Also fix an outdated link and
remove irrelevant mention about the `post-upstream-clone` action which
is no more used in `.packit.yaml` config.
@psss psss force-pushed the lzachar-dockerfile-changes branch from 99d5807 to 009fc0b Compare January 25, 2024 10:28
@psss
Copy link
Collaborator

psss commented Jan 25, 2024

/packit test -i full

@psss psss merged commit 009fc0b into main Jan 25, 2024
17 of 18 checks passed
@psss psss deleted the lzachar-dockerfile-changes branch January 25, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants