-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic ref evaluation support to plan import #1833
Conversation
This should address #1832 |
6db26cc
to
a45f2f7
Compare
a8235ee
to
6245306
Compare
One more thing I didn't like is the lack of information about the imported plan. I have added a commit improving this a bit, although I am really not sure the approach is correct (definitely not pretty).
|
09a7449
to
5a091f3
Compare
0fd2f6f
to
e9d8346
Compare
f4df534
to
b1b0b9f
Compare
39f2e39
to
a2cde4c
Compare
Hi @psss @happz @thrix ,
|
I have added back the test update so now there will be failures due to the newly added warning. |
OK, I did one more updated, adding extra |
af3c9b6
to
1cd6444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing comments, looks good. I've rebased on the latest main
and added just a couple of minor changes in f9dcd90.
Add tests for test plan import with dynamic ref. Clone repo if not enough data to eval dynamic ref. Log import plan details.
No description provided.