Define a "plugin registry" class #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
explore-plugins-with-better-logging
branch
from
5abb3fd
to
fd333ef
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
from
fd333ef
to
c3bdbf9
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
2 times, most recently
from
c06d64d
to
23222bb
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
from
23222bb
to
8924418
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
2 times, most recently
from
843d30d
to
be83a35
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
from
be83a35
to
4a1d86a
Compare
psss
force-pushed
the
explore-plugins-with-better-logging
branch
from
47d5143
to
f720ccc
Compare
happz
force-pushed
the
explore-plugins-with-better-logging
branch
from
f720ccc
to
05b5746
Compare
happz
force-pushed
the
plugin-registry-as-a-class
branch
from
956f46f
to
73851e1
Compare
happz
force-pushed
the
plugin-registry-as-a-class
branch
3 times, most recently
from
5a4f3c9
to
b9ab7f5
Compare
|
Downstream patch has been submitted. |
psss
approved these changes
Jun 7, 2023
happz
force-pushed
the
plugin-registry-as-a-class
branch
from
b9ab7f5
to
df36f3d
Compare
The class is fairly trivial, but draws a clear distinction between an arbitrary dictionary and a "plugin registry" object. New types of plugins are heading our way, therefore making boundaries more visible, to clear up responsibilities.
psss
force-pushed
the
plugin-registry-as-a-class
branch
from
df36f3d
to
8613691
Compare
|
Updated |
tmt/-/merge_requests/82 for those interested. Edit: And Milos was faster with his /81 so I merged that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class is fairly trivial, but draws a clear distinction between an arbitrary dictionary and a "plugin registry" object. New types of plugins are heading our way, therefore making boundaries more visible, to clear up responsibilities.
Part of the effort behind #1838 and #216.