Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modification of imported plans #1788 #1886

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Allow modification of imported plans #1788 #1886

merged 1 commit into from
Jun 21, 2023

Conversation

ZelenyMartin
Copy link
Contributor

Related #1788

@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch from 97b6ac6 to 20d68f4 Compare March 8, 2023 13:46
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch 2 times, most recently from 47658fe to ebfbca7 Compare March 28, 2023 08:52
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch from ebfbca7 to fd6369b Compare May 4, 2023 09:00
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch 2 times, most recently from 55305be to 70ede57 Compare May 18, 2023 13:30
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch 5 times, most recently from 74f8b60 to 9eb32af Compare June 15, 2023 14:01
@ZelenyMartin
Copy link
Contributor Author

/packit retest-failed

@ZelenyMartin ZelenyMartin marked this pull request as ready for review June 19, 2023 07:38
adiosnb
adiosnb approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@adiosnb adiosnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

psss
psss requested changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions.

tests/plan/import/main.fmf Outdated Show resolved Hide resolved
tests/plan/import/mod-plan-data/plans.fmf Outdated Show resolved Hide resolved
@ZelenyMartin ZelenyMartin added this to the 1.25 milestone Jun 20, 2023
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch from a6ce7fa to e55fc7b Compare June 20, 2023 08:53
@ZelenyMartin ZelenyMartin requested a review from psss June 20, 2023 08:58
@psss psss self-assigned this Jun 20, 2023
psss
psss approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch from e55fc7b to 9be1b20 Compare June 20, 2023 14:25
@ZelenyMartin
Allow modification of imported plans
afd06b6 
Plan doing an import of another plan (has the key 'plan' with the key
'import') now can set environment variable (in key 'environment') and
this variable can be used in modification of imported plan.

Resolves: #1788
@ZelenyMartin ZelenyMartin force-pushed the mzeleny-modification-imported-plans branch from 9be1b20 to afd06b6 Compare June 20, 2023 14:26
@psss psss merged commit afd06b6 into main Jun 21, 2023
15 checks passed
@psss psss deleted the mzeleny-modification-imported-plans branch June 21, 2023 07:08
@ZelenyMartin ZelenyMartin restored the mzeleny-modification-imported-plans branch June 21, 2023 08:03
ZelenyMartin added a commit that referenced this pull request Jun 21, 2023
@ZelenyMartin
Documentation Allow modification of imported plans
124efcd 
Finalizing test and documenting feature introduced in PR #1886
@ZelenyMartin ZelenyMartin mentioned this pull request Jun 21, 2023
Merged
ZelenyMartin added a commit that referenced this pull request Jun 21, 2023
@ZelenyMartin
Documentation Allow modification of imported plans
6d8daf3 
Finalizing test and documenting feature introduced in PR #1886
ZelenyMartin added a commit that referenced this pull request Jun 22, 2023
@ZelenyMartin
Documentation Allow modification of imported plans
578843f 
Finalizing test and documenting feature introduced in PR #1886
psss pushed a commit that referenced this pull request Jun 22, 2023
@ZelenyMartin @psss
Document how to modify imported plans
532d0a2 
Finalizing test and documenting feature introduced in PR #1886
@ZelenyMartin ZelenyMartin deleted the mzeleny-modification-imported-plans branch June 23, 2023 08:22
@psss psss changed the title Allow modification of imported plans #1788 Allow modification of imported plans #1788 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@adiosnb adiosnb adiosnb approved these changes

@happz happz Awaiting requested review from happz happz is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees

@psss psss

Labels
import plans
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZelenyMartin @psss @adiosnb