Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runner property to run with test runner facts #1942

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add runner property to run with test runner facts #1942

merged 1 commit into from
Oct 23, 2023

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 26, 2023 •
edited
Loading

We do have guest facts, we can also logs something about the control box, for debugging purposes.

(tmt) [pts-2:0]: mprchlik@multivac [host-object] ~/git/tmt $ tmt -c trigger=commit -vv run -a plan -n '^/plans/features/core$'
/home/mprchlik/tmt-workdirs/run-077
host
    arch: x86_64
    distro: Fedora Linux 37 (Workstation Edition)
    kernel: 6.2.8-200.fc37.x86_64
    package manager: dnf
    selinux: yes
Found 1 plan.

/plans/features/core
summary: Verify core functionality
    discover
        how: fmf
        directory: /home/mprchlik/git/tmt
...

@happz
Copy link
Collaborator Author

happz commented Mar 28, 2023

Note for @happz: incorporate "selinux enabled" from #1930

@happz happz requested a review from thrix as a code owner April 11, 2023 07:52
@happz happz force-pushed the guest-facts branch 2 times, most recently from 4a432cc to 7b8b943 Compare April 17, 2023 07:37
@thrix
Copy link
Collaborator

thrix commented Apr 17, 2023

@happz seems this needs a rebase?

@happz happz added the blocked The merging of PR is blocked on some other issue label Apr 17, 2023
@happz
Copy link
Collaborator Author

happz commented Apr 17, 2023

@happz seems this needs a rebase?

I'll make a rebase once #1890 gets merged, I tried it right now and it did not go well :/

@happz happz force-pushed the guest-facts branch 4 times, most recently from 60aedfd to ce66b47 Compare May 15, 2023 14:38
Base automatically changed from guest-facts to main May 16, 2023 09:50
@thrix
Copy link
Collaborator

thrix commented Sep 18, 2023

@happz what is the status for this one? Should we review? seems quite old, review asked, but no milestone?

@happz
Copy link
Collaborator Author

happz commented Sep 18, 2023

@thrix ignore it, please, it's not part of any milestone.

@happz happz marked this pull request as draft September 18, 2023 11:11
@happz happz added this to the 1.29 milestone Sep 22, 2023
@happz happz added logging and removed blocked The merging of PR is blocked on some other issue labels Sep 22, 2023
@happz happz marked this pull request as ready for review September 22, 2023 13:17
@thrix
Copy link
Collaborator

thrix commented Oct 10, 2023

This is now ready to be reviewed, tests need to be checked

@happz happz added the blocking other work An important PR, blocking other PRs or issues label Oct 16, 2023
psss
psss requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! Added a few thoughts.

tests/provision/facts/main.fmf Outdated Show resolved Hide resolved
tmt/base.py Outdated Show resolved Hide resolved
tmt/cli.py Outdated Show resolved Hide resolved
@happz happz requested a review from janhavlin as a code owner October 18, 2023 08:02
thrix
thrix approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nitpick

tmt/base.py Outdated Show resolved Hide resolved
@psss psss self-assigned this Oct 23, 2023
psss
psss approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all comments!

@happz @psss
Add runner property to run with test runner facts
993280a 
We do have guest facts, we can also logs something about the
control box, for debugging purposes.
@psss psss changed the title Add "host" property to run, representing the tmt host machine Add runner property to run with test runner facts Oct 23, 2023
@psss psss merged commit 993280a into main Oct 23, 2023
16 checks passed
@psss psss deleted the host-object branch October 23, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@FrNecas FrNecas Awaiting requested review from FrNecas

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
blocking other work An important PR, blocking other PRs or issues logging
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@happz @thrix @lukaszachy @psss