Identify incorrect subcommand after a correct one #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idorax
force-pushed
the
dev-huanli-2022-20230426-cli
branch
from
a17ef10
to
c89bfcb
Compare
|
Hi @lukaszachy and @happz, would you please help to review this PR? Thanks! |
idorax
force-pushed
the
dev-huanli-2022-20230426-cli
branch
from
c89bfcb
to
e06d01f
Compare
idorax
force-pushed
the
dev-huanli-2022-20230426-cli
branch
from
e06d01f
to
66e19a7
Compare
happz
reviewed
Jun 2, 2023
psss
reviewed
Jun 5, 2023
idorax
force-pushed
the
dev-huanli-2022-20230426-cli
branch
5 times, most recently
from
83912d2
to
31d9666
Compare
psss
reviewed
Jun 6, 2023
idorax
force-pushed
the
dev-huanli-2022-20230426-cli
branch
from
b9e96e1
to
f84dc50
Compare
psss
approved these changes
Jun 6, 2023
If a correct subcommand is followed by an incorrect one, the CLI should
raise a proper error. For example,
$ tmt run --rm pl disc provin -h local
`disc` is the subcommand `discover` for short, but `provin` is not
`provision` for short, which is invalid actually. Hence, CLI should
not ignore the invalid short name of the subcommand `provision`.
Signed-off-by: Vector Li <huanli@redhat.com>
Co-authored-by: Miloš Prchlík <mprchlik@redhat.com>
psss
force-pushed
the
dev-huanli-2022-20230426-cli
branch
from
f84dc50
to
7280d02
Compare
|
Rebased and squashed. The test failures which appeared in the latest run were all irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2022