Add a single tmpdir fixture for all supported Python versions
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
unit-test-tmp-path-wrappers
branch
5 times, most recently
from
9de95ad
to
ba8cb69
Compare
happz
added
the
no functional change
happz
force-pushed
the
unit-test-tmp-path-wrappers
branch
from
ba8cb69
to
b59db88
Compare
happz
force-pushed
the
unit-test-tmp-path-wrappers
branch
2 times, most recently
from
cca11d9
to
8075d7e
Compare
psss
changed the title
tmpdir fixture for all supported Python versions
psss
requested changes
Jun 29, 2023
happz
force-pushed
the
unit-test-tmp-path-wrappers
branch
from
8075d7e
to
eb832ab
Compare
psss
approved these changes
Jun 29, 2023
See comments in `conftest.py`, but in general: * because of our code, we would like to use `tmp_path` and `Path` it returns, * but we have also our custom `tmt.utils.Path` we should be using instead of the original `pathlib.Path`, * because of RHEL8, we also get pytest without `tmp_path` fixture, * and `tmpdir` fixture returns `py.path.local`. The patch adds our custom fixture which returns `tmt.utils.Path` no matter what pytest we get. It's achieved by a test import, trivial wrapper class, and two fixtures hiding the actual pytest fixture involved.
psss
force-pushed
the
unit-test-tmp-path-wrappers
branch
from
eb832ab
to
4e05f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in
conftest.py, but in general:tmp_pathandPathit returns,tmt.utils.Pathwe should be using instead of the originalpathlib.Path,tmp_pathfixture,tmpdirfixture returnspy.path.local.The patch adds our custom fixture which returns
tmt.utils.Pathno matter what pytest we get. It's achieved by a test import, trivial wrapper class, and two fixtures hiding the actual pytest fixture involved.