Replace named tuples with data classes #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
dataclass-instead-of-namedtuple
branch
2 times, most recently
from
498fd2a
to
a54a068
Compare
happz
added
the
no functional change
happz
force-pushed
the
dataclass-instead-of-namedtuple
branch
from
a54a068
to
532b5a5
Compare
happz
force-pushed
the
dataclass-instead-of-namedtuple
branch
from
532b5a5
to
10a82e3
Compare
|
Downstream patch has been submitted. |
happz
force-pushed
the
dataclass-instead-of-namedtuple
branch
from
10a82e3
to
197f0f7
Compare
Data classes are superior in every aspect except one, data classes
cannot be unpacked:
```python
stdout, _ = ShellScript(...).run()
```
But this is rarely used to for anything that could not be replaced with
a data class:
```python
stdout,_ = ShellScript(...).run()
self.info('foo', stdout)
```
As `stdout` exists only to be passed to another call, without any
computation, a data class without unpacking does not look like a downgrade:
```
output = ShellScript(...).run()
self.info('foo', output.stdout)
```
Data classes are often faster, can be made immutable, and are aligned
with the rest of tmt code base where named tuples are exception, while
data classes are very common.
psss
force-pushed
the
dataclass-instead-of-namedtuple
branch
from
197f0f7
to
ccfb0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data classes are superior in every aspect except one, data classes cannot be unpacked:
But this is rarely used to for anything that could not be replaced with a data class:
As
stdoutexists only to be passed to another call, without any computation, a data class without unpacking does not look like a downgrade:Data classes are often faster, can be made immutable, and are aligned with the rest of tmt code base where named tuples are exception, while data classes are very common.