Make relevancy/coverage linters to not re-read fmf files #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
changed the title
happz
force-pushed
the
lint-prepare-linters
branch
from
fd674c6
to
541fd43
Compare
happz
force-pushed
the
lint-prepare-linters
branch
from
541fd43
to
30e8bcc
Compare
happz
force-pushed
the
metadata-linters-dont-reread-source-fmf
branch
from
af2d7b6
to
0b84ad8
Compare
happz
force-pushed
the
lint-prepare-linters
branch
from
30e8bcc
to
19b67e3
Compare
happz
force-pushed
the
lint-prepare-linters
branch
from
19b67e3
to
8689fa3
Compare
happz
force-pushed
the
lint-prepare-linters
branch
from
8689fa3
to
1aebcde
Compare
psss
force-pushed
the
lint-prepare-linters
branch
from
1aebcde
to
beec739
Compare
happz
force-pushed
the
metadata-linters-dont-reread-source-fmf
branch
2 times, most recently
from
50bb346
to
0155d3f
Compare
happz
force-pushed
the
metadata-linters-dont-reread-source-fmf
branch
from
0155d3f
to
bf957db
Compare
psss
requested changes
Jun 29, 2023
happz
force-pushed
the
metadata-linters-dont-reread-source-fmf
branch
from
bf957db
to
1ebdbdc
Compare
psss
approved these changes
Jun 29, 2023
Two test linters checking for legacy constructs were re-reading the original fmf sources, to focus on leaf node only. Patch changes the linters: * both now focus on loaded fmf data, i.e. `self.node` is inspected. * this may report keys defined by parents in the node fmf tree, but that is expected - the key is defined, somewhere, and it's inherited by the test metadata, user should be aware. The current implementation might miss this case, although it should be said, relevancycoverage inheritance is probably pretty rare. * optional `relevancy` key fix is applied only when relevancy is defined in the leaf node, i.e. in the test's direct metadata. It relevancy's inherited, the fix would be impractical as it would fix the wrong node. To get the right tools for this, two functions from `tmt.identifier` were moved into `tmt.utils` and generalized a bit. With this change, two extra reads of fmf files for each test visited by `tmt lint` are gone, dropping `tmt test lint` of tmt repo from 3.7 down to 2.6 seconds (on my laptop, YMMV).
psss
force-pushed
the
metadata-linters-dont-reread-source-fmf
branch
from
9337712
to
0d2b05d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two test linters checking for legacy constructs were re-reading the original fmf sources, to focus on leaf node only. Patch changes the linters:
self.nodeis inspected.relevancykey fix is applied only when relevancy is defined in the leaf node, i.e. in the test's direct metadata. It relevancy's inherited, the fix would be impractical as it would fix the wrong node.To get the right tools for this, two functions from
tmt.identifierwere moved intotmt.utilsand generalized a bit.With this change, two extra reads of fmf files for each test visited by
tmt lintare gone, droppingtmt test lintof tmt repo from 3.7 down to 2.6 seconds (on my laptop, YMMV).