Additional ruff rules and fixes #2176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhoyer
requested review from
Tiboris,
frantisekz,
psss,
lukaszachy,
happz and
thrix
as code owners
martinhoyer
commented
Jun 27, 2023
tests/unit/test_report_junit.py
Outdated
| assert expected_value == actual_value, (f"Attribute mismatch at {tree_path_joined}: " | ||
| f"found {actual_name}=\"{actual_value}\"") | ||
| assert expected_name == actual_name, (f'Attribute mismatch at {tree_path_joined}: ' | ||
| f'expected {expected_name}="{expected_value}"') |
There was a problem hiding this comment.
It would be cool to standardize single or double quotes by default.
Q000 rule(currently disabled) can be configured to preferred single/double quote style.
Closed
martinhoyer
changed the title
martinhoyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just simple non-breaking (I think) changes needed to be able to enable a few more cool checks.
Not much to comment, in addition to what's written in the commits. Few notes:
# coding: utf-8is redundant on Python 3Noneby default.