Add skip as a supported custom result outcome
#2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoncek
requested review from
psss,
lukaszachy,
happz and
thrix
as code owners
happz
reviewed
Sep 12, 2023
happz
reviewed
Sep 12, 2023
mkoncek
changed the title
|
@happz Rebased, I think i addressed all the issues. |
happz
approved these changes
Sep 14, 2023
psss
requested changes
Sep 14, 2023
|
The final summary shows: Perhaps we could use |
|
/packit test |
|
@mkoncek, are you going to address the pending comments? |
Yes, I have been meaning to do it for some time... Regarding documentation, the wording will need to be very precise. |
|
/packit test |
lukaszachy
previously requested changes
Oct 5, 2023
psss
approved these changes
Oct 6, 2023
|
/packit test |
|
Some changes will be needed also on the Testing Farm side: TFT-2282 |
|
/packit test |
The use case is when a single tmt test produces multiple results but some of them were not executed because the process decided so. It should be visible to the user that such a test exists and that there is not a bug in the implementation which caused the test to be missing. Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
|
/packit test |
psss
changed the title
skip custom result outcomeskip as a supported custom result outcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed with @lukaszachy probably a month ago the purpose of this is to explicitly state that a test was not executed.
The use case is when a single tmt test produces multiple results but some of them were not executed because the implementation decided so. It should be visible to the user that such a test exists and that there is not a bug in the implementation which caused the test to be missing.
It is still an open question how such cases should be displayed in Fedora's CI.