Check for files in rpm-ostree install script
#2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KwisatzHaderach
added
bug
KwisatzHaderach
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
KwisatzHaderach
added
the
full test
happz
reviewed
Feb 19, 2024
psss
reviewed
Feb 20, 2024
|
That is great, thanks, didn't realise we already have some tests for ostree envs. |
When installing files (like /usr/bin/flock) installation check fails only with 'rpm -q' and on rpm-ostree system it might be a problem as it changes image digest Also installation will be faster with this check
psss
force-pushed
the
install_check_files
branch
from
e1f8aec
to
3999dfa
Compare
psss
changed the title
rpm-ostree install script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing files (like /usr/bin/flock) installation check fails only with 'rpm -q' and on rpm-ostree system it might be a problem as it changes image digest (caused a failed upgrade test on our env)
Also installation will be faster with this check
Pull Request Checklist