Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use "become" image to fix sudo-related trouble in /tests/provision/user #2892

Merged
merged 2 commits into from Apr 29, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Apr 26, 2024

The test started to fail because /usr/bin/flock is not preinstalled and the default Fedora image does not come with password-less sudo enabled out of the box. Therefore we use the image we build for /tests/provision/become, give a nice name other images will follow Soon(TM), and use it in a test that exercises a non-privileged access.

Pull Request Checklist

  • implement the feature

…/user

The test started to fail because `/usr/bin/flock` is not preinstalled
and the default Fedora image does not come with password-less `sudo`
enabled out of the box. Therefore we use the image we build for
`/tests/provision/become`, give a nice name other images will follow
Soon(TM), and use it in a test that exercises a non-provileged access.
@happz happz added the tmt tests Improvements or additions to test coverage of tmt itself label Apr 26, 2024
@happz happz added this to the 1.33 milestone Apr 26, 2024
@happz happz added the full test Pull request is ready for the full test execution label Apr 26, 2024
@happz
Copy link
Collaborator Author

happz commented Apr 26, 2024

/packit test

@psss
Copy link
Collaborator

psss commented Apr 26, 2024

Seems that /tests/unit/with-system-packages/basic fails with:

No rule to make target 'image-tests-fedora-become', needed by 'images-unit-tests'.

@happz
Copy link
Collaborator Author

happz commented Apr 26, 2024

Seems that /tests/unit/with-system-packages/basic fails with:

No rule to make target 'image-tests-fedora-become', needed by 'images-unit-tests'.

Fixed just now. At the last moment, I renamed the target, hoping to use a path-like name rather than encoding hierarchy with dashes...

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@happz happz merged commit 481deb1 into main Apr 29, 2024
19 of 20 checks passed
@happz happz deleted the become-image-reuse-in-provision-user branch April 29, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full test Pull request is ready for the full test execution tmt tests Improvements or additions to test coverage of tmt itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants