Run the no-commit-to-branch check only locally

[psss]

It does not make sense to run this pre-commit check in pull requests or when merging to the main branch on GitHub. Also update actions to the latest versions to get rid of warnings.

[lukaszachy]

I got confused by "It does not make sense to run it when merging to main." as almost every PR is aiming to be merged into main. But as gh runs action after it is merged then OK to disable it.

BTW summary and PR doesn't match - this PR disables whole pre-commit, not just one hook, right? Is there a way to disable just this check?

[psss]

Is there a way to disable just this check?

Hm, don't know if it's possible to only disable a specific check. @thrix, any hint?

BTW summary and PR doesn't match - this PR disables whole pre-commit, not just one hook, right?

Ah, right, will update the title if we keep it as it is.

[lukaszachy]

@psss An attempt to disable single hook.

The SKIP for pre-commit is documented at https://pre-commit.com/#temporarily-disabling-hooks

Checking event - https://docs.github.com/en/actions/learn-github-actions/contexts#example-usage-of-the-github-context
Setting variable -https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

[happz]

Interestingly, in the Artemis project, pre-commit runs after merge event, against main, and it reports no problems with main branch... I'm puzzled :/

[psss]

Interestingly, in the Artemis project, pre-commit runs after merge event, against main, and it reports no problems with main branch... I'm puzzled :/

Hmmm, that's really weird.

@psss An attempt to disable single hook.

Great! Thanks for preparing this. Tried with 8366c74 and confirm it works nicely! Let's approve and merge soon!

[LecrisUT]

Doing a code search. Examples with --branch seem to be using pre-commit-ci. Without it the default is to use master and main, qnd I see it used with the pre-commit action without erroring 🤷‍♂️

[happz]

Nope, no idea why it works in Artemis and fails here. no-commit-to-banch is apparently executed against main at https://gitlab.com/testing-farm/artemis/-/jobs/6784553461#L435, and it's green and happy. The only idea I have is that it's not checking any new commit, it's running against main that's been already enriched with new commits, it's done and no changes are pending to be committed to main. Is that different than Github actions we saw fail? Running before the actual merge? I suppose in that case this check might start to complain.

[martinhoyer]

Just a quick question - why not add it directly to the workflow env: key?

[psss]

Just a quick question - why not add it directly to the workflow env: key?

Yeah, now that the condition was dropped this can be simplified. Updated.

[psss]

Also updated to the latest versions of actions to get rid of the warnings.