-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the cpu.hyper-threading
hardware requirement
#2949
base: main
Are you sure you want to change the base?
Conversation
spec/hardware/cpu.fmf
Outdated
@@ -55,6 +55,9 @@ description: | | |||
- "!= flag4" | |||
... | |||
|
|||
# Boolean, whether the cpu supports hyper-threading. | |||
hyper: true| false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents: 'hyper' is one of the sooo overloaded buzzwords that I for one would rather see full form rather than "hyper". hyperthreading
or hyper-threading
would be way more readable to me, I wouldn't have to worry some CPU vendor comes up with yet another "hyper" technology :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One extra space left, it'd be nice to remove it.
Make sense,and updated^^
…On Tue, May 21, 2024 at 6:07 PM Miloš Prchlík ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/cpu.fmf
<#2949 (comment)>:
> @@ -55,6 +55,9 @@ description: |
- "!= flag4"
...
+ # Boolean, whether the cpu supports hyper-threading.
+ hyper: true| false
My two cents: 'hyper' is one of the sooo overloaded buzzwords that I for
one would rather see full form rather than "hyper". hyperthreading or
hyper-threading would be way more readable to me, I wouldn't have to
worry some CPU vendor comes up with yet another "hyper" technology :)
—
Reply to this email directly, view it on GitHub
<#2949 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23ATZH62OGNSV3QUPSLZDMMENAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGE2TKOBSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
spec/hardware/cpu.fmf
Outdated
@@ -97,6 +100,11 @@ example: | |||
cpu: | |||
cores: ">= 4" | |||
|
|||
- | | |||
# Request a CPU supports hyper-threading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Request a CPU supports hyper-threading. | |
# Request a CPU with hyper-threading enabled. |
Small nuance shouldn't it be with hyper-threading enabled
rather than just supported?
tmt/schemas/provision/hardware.yaml
Outdated
@@ -97,6 +97,8 @@ definitions: | |||
anyOf: | |||
- type: string | |||
- type: integer | |||
hyper: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hyper: | |
hyper-threading: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review,updated:)
yes, enabled is better here
…On Tue, May 21, 2024 at 6:42 PM Cristian Le ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/cpu.fmf
<#2949 (comment)>:
> @@ -97,6 +100,11 @@ example:
cpu:
cores: ">= 4"
+ - |
+ # Request a CPU supports hyper-threading.
⬇️ Suggested change
- # Request a CPU supports hyper-threading.
+ # Request a CPU with hyper-threading enabled.
Small nuance shouldn't it be with hyper-threading enabled rather than
just supported?
------------------------------
In tmt/schemas/provision/hardware.yaml
<#2949 (comment)>:
> @@ -97,6 +97,8 @@ definitions:
anyOf:
- type: string
- type: integer
+ hyper:
⬇️ Suggested change
- hyper:
+ hyper-threading:
—
Reply to this email directly, view it on GitHub
<#2949 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23GXRY76BSISFXNGB5TZDMQINAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGIZTSNBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
cpu.hyper
hardware requirementcpu.hyper-threading
hardware requirement
@skycastlelily when you have some spare time, rebase on top of the recent main, please, and resolve conflicts. |
Updated^^
…On Sat, Jun 15, 2024 at 4:43 PM Miloš Prchlík ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> when you have some
spare time, rebase on top of the recent main, please, and resolve conflicts.
—
Reply to this email directly, view it on GitHub
<#2949 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23AUQ5YZHI2AU53RUSTZHP5BDAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGIYTKMJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Pull Request Checklist