Parse the cpu.hyper-threading hardware requirement
#2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skycastlelily
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
May 21, 2024
spec/hardware/cpu.fmf
Outdated
| @@ -55,6 +55,9 @@ description: | | |||
| - "!= flag4" | |||
| ... | |||
|
|
|||
| # Boolean, whether the cpu supports hyper-threading. | |||
| hyper: true| false | |||
There was a problem hiding this comment.
My two cents: 'hyper' is one of the sooo overloaded buzzwords that I for one would rather see full form rather than "hyper". hyperthreading or hyper-threading would be way more readable to me, I wouldn't have to worry some CPU vendor comes up with yet another "hyper" technology :)
There was a problem hiding this comment.
One extra space left, it'd be nice to remove it.
|
Make sense,and updated^^
…On Tue, May 21, 2024 at 6:07 PM Miloš Prchlík ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/cpu.fmf
<#2949 (comment)>:
> @@ -55,6 +55,9 @@ description: |
- "!= flag4"
...
+ # Boolean, whether the cpu supports hyper-threading.
+ hyper: true| false
My two cents: 'hyper' is one of the sooo overloaded buzzwords that I for
one would rather see full form rather than "hyper". hyperthreading or
hyper-threading would be way more readable to me, I wouldn't have to
worry some CPU vendor comes up with yet another "hyper" technology :)
—
Reply to this email directly, view it on GitHub
<#2949 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23ATZH62OGNSV3QUPSLZDMMENAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGE2TKOBSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
LecrisUT
reviewed
May 21, 2024
spec/hardware/cpu.fmf
Outdated
| @@ -97,6 +100,11 @@ example: | |||
| cpu: | |||
| cores: ">= 4" | |||
|
|
|||
| - | | |||
| # Request a CPU supports hyper-threading. | |||
There was a problem hiding this comment.
Suggested change
| # Request a CPU supports hyper-threading. | |
| # Request a CPU with hyper-threading enabled. |
Small nuance shouldn't it be with hyper-threading enabled rather than just supported?
tmt/schemas/provision/hardware.yaml
Outdated
| @@ -97,6 +97,8 @@ definitions: | |||
| anyOf: | |||
| - type: string | |||
| - type: integer | |||
| hyper: | |||
There was a problem hiding this comment.
Suggested change
| hyper: | |
| hyper-threading: |
There was a problem hiding this comment.
Thanks for your review,updated:)
|
yes, enabled is better here
…On Tue, May 21, 2024 at 6:42 PM Cristian Le ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/cpu.fmf
<#2949 (comment)>:
> @@ -97,6 +100,11 @@ example:
cpu:
cores: ">= 4"
+ - |
+ # Request a CPU supports hyper-threading.
⬇️ Suggested change
- # Request a CPU supports hyper-threading.
+ # Request a CPU with hyper-threading enabled.
Small nuance shouldn't it be with hyper-threading enabled rather than
just supported?
------------------------------
In tmt/schemas/provision/hardware.yaml
<#2949 (comment)>:
> @@ -97,6 +97,8 @@ definitions:
anyOf:
- type: string
- type: integer
+ hyper:
⬇️ Suggested change
- hyper:
+ hyper-threading:
—
Reply to this email directly, view it on GitHub
<#2949 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23GXRY76BSISFXNGB5TZDMQINAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGIZTSNBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
skycastlelily
changed the title
cpu.hyper hardware requirementcpu.hyper-threading hardware requirement
|
@skycastlelily when you have some spare time, rebase on top of the recent main, please, and resolve conflicts. |
|
Updated^^
…On Sat, Jun 15, 2024 at 4:43 PM Miloš Prchlík ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> when you have some
spare time, rebase on top of the recent main, please, and resolve conflicts.
—
Reply to this email directly, view it on GitHub
<#2949 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23AUQ5YZHI2AU53RUSTZHP5BDAVCNFSM6AAAAABIBI2ZJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGIYTKMJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
happz
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist