Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for pip test installation on py3.13 #3043

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Workaround for pip test installation on py3.13 #3043

merged 1 commit into from
Jun 25, 2024

Conversation

martinhoyer
Copy link
Collaborator

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@martinhoyer
Copy link
Collaborator Author

/packit test

@martinhoyer martinhoyer added the full test Pull request is ready for the full test execution label Jun 24, 2024
@martinhoyer
Copy link
Collaborator Author

/packit test

@martinhoyer
Copy link
Collaborator Author

tmt[all] fails due to dependencies of plugin packages. This test could be disabled on Python3.13 for now.
pip mini fails do to hgrecco/pint#1969. I'm guessing could also be disabled?

@happz happz added this to the 1.35 milestone Jun 25, 2024
@happz happz added the must high priority label Jun 25, 2024
@martinhoyer
Copy link
Collaborator Author

Adding commits from #3014 and #2741 temporarily to check if the whole pipeline would be green.

@martinhoyer martinhoyer marked this pull request as ready for review June 25, 2024 14:34
@martinhoyer martinhoyer self-assigned this Jun 25, 2024
@happz happz added the ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jun 25, 2024
@martinhoyer
Copy link
Collaborator Author

@psss Could you take a look if it's good for merging please?

@happz
Copy link
Collaborator

happz commented Jun 25, 2024

Unrelated failure, merging.

@happz happz merged commit 1ec3309 into teemtee:main Jun 25, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@martinhoyer martinhoyer

Labels
full test Pull request is ready for the full test execution must high priority ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinhoyer @happz @KwisatzHaderach