Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Val err details #12

Merged
merged 19 commits into from
Jul 9, 2021
Merged

Val err details #12

merged 19 commits into from
Jul 9, 2021

Commits on Jul 5, 2021

  1. Added a source_type and message field to ValidationError. 

    - ValidationError should have more detail.
- ValidationError::message should maybe have a String so people can use
format! to generate the messages.
    ObsceneGiraffe committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    9c2a110 View commit details
    Browse the repository at this point in the history

  2. Forgot the changes in lib.

    ObsceneGiraffe committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    84a0748 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Merge branch 'master' into val_err_details

    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    da75369 View commit details
    Browse the repository at this point in the history

  2. Made the ValidationError message for Ensure closures lowercase and 

    remove the period.
    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    545cf7c View commit details
    Browse the repository at this point in the history

  3. Debug nad Display impls for ValidationError use the message field.

    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    228ef1d View commit details
    Browse the repository at this point in the history

  4. ValidationError::message retyped from &str to String. 

    - String allows for error messages constructed using format! and such
macros.
    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    bfa720a View commit details
    Browse the repository at this point in the history

  5. ConstructionError includes the input value in the error mesasge. 

    - The message field is removed as there is no need for custom error
  messages yet.
- The type alias is passed given to the Error so it can print it.
    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    bf23b9c View commit details
    Browse the repository at this point in the history

  6. Restored the assert_matches in the tests.

    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    25abe8f View commit details
    Browse the repository at this point in the history

  7. Made the ConstructionError::guarded_type_name a &'static str.

    ObsceneGiraffe committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    293c758 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Renamed ConstructionError back to ValidationError. 

    - There was a plan to have two errors, one for Construction and another
for Mutation. This is not going ahead due to it requiring major arch
changes.
    ObsceneGiraffe committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    db02884 View commit details
    Browse the repository at this point in the history

  2. Fixed a sloppy rename.

    ObsceneGiraffe committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    3adae1f View commit details
    Browse the repository at this point in the history

  3. Minor fixes

    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    5db539b View commit details
    Browse the repository at this point in the history

  4. Add comment about test test_deps

    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    6a9684a View commit details
    Browse the repository at this point in the history

  5. Check if define! works with non-clonable types

    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    426e4bc View commit details
    Browse the repository at this point in the history

  6. Removed value from ValidationError. 

    - The value would force the users type to implement `Clone`.
    ObsceneGiraffe committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c85f522 View commit details
    Browse the repository at this point in the history

  7. Reinstated value to ValidationError but as a String. 

    - This allows the error to store a value without a generic `T: Clone +
Debug`
    ObsceneGiraffe committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    1cc5924 View commit details
    Browse the repository at this point in the history

  8. Remove junk file

    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b779b76 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'val_err_details' of github.com:ObsceneGiraffe/prae into… 

    … val_err_details
    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    49409f8 View commit details
    Browse the repository at this point in the history

  10. Fix comment

    @teenjuna
    teenjuna committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    39e8928 View commit details
    Browse the repository at this point in the history