Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor icons are slightly cropped #1581

Closed
Dune-jr opened this issue Oct 28, 2018 · 16 comments
Closed

Armor icons are slightly cropped #1581

Dune-jr opened this issue Oct 28, 2018 · 16 comments

Comments

@Dune-jr
Copy link
Member

Dune-jr commented Oct 28, 2018

Cut on the right and the bottom:
image

@nheir
Copy link
Contributor

nheir commented Oct 28, 2018

Looks like it's also the case for the heart icons

@oy
Copy link
Member

oy commented Oct 29, 2018

Would be best to fix it in the image, so they don't touch the border. Also the empty heart has a different offset from the top than the filled one.

@Zatline
Copy link
Member

Zatline commented Oct 29, 2018

this is a personal remake of the game.png I done years ago it's pretty close to the original all colors, shapes and sizes should be 1:1 the original only difference is the style of these armor and health icons unfortunatly never liked the original, this also is a repost from the discord channel;

game_

personaly played with it a lot back in the days I think the weapons appear sharper in game if my memory is correct (edit: memory had me mistaken actually the opposit) the withe flag was for a new gametype I had in mind calld "hold the flag" it's death match with an objectiv player who holds the flag longest wins

@Sonix-
Copy link
Member

Sonix- commented Oct 30, 2018

@Zatline looks good to me, the hp always needed a little retouch in my opinion.
Just a little remark, remove the white flag and also the black background (could be distracting and annoying to some) of the empty heart and armour and also the flag wooden bases look a bit smaller, ah and the sword too.
Some possibilities:
(your orange shadow looks a bit darker)
game_edit3
game_edit2
game_edit1

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 30, 2018

@Sonix- cool, I like all of these!

@oy
Copy link
Member

oy commented Oct 30, 2018

Should probably use the same colour for armor in the hud and as pickup.

@Fisico
Copy link
Contributor

Fisico commented Oct 30, 2018

i really like the redesigned hearts and armour. But i agree with oy the pickup color should be identical to the hud color.

@android272
Copy link

I really like these. The hearts, shields, and damage stars needed a redesign anyway as they have gradients and don't use the same shading as the guns do. Plus these shields are rounder and a lot of the world in Teeworlds is supposed to be round. EX: trees, Tee houses, bushes etc. so these look a lot more teeish. I give my approval once the right colors are picked. When I get home I will make these changes in the graphics redesign @oy and I are working on.

@Zatline
Copy link
Member

Zatline commented Oct 31, 2018

@android272 @oy what graphic redisgn? dude everything is there and already been remade by Landil and me it's all on Dropbox stop it!! I'll share the files no worrie just need time for it focus on making some new stuff instead can you contact me on Discord I might have a project for you!

@android272
Copy link

@Zatline so I have remade nearly 100% of the Teeworlds art. I did an almost 1 to 1 redraw (basically I traced all the art) as an SVG. The devs did not have the original SVG source files. or at least oy did not, I don't know. TW 0.6 needed some post-processing done to the assets to look good, TW 0.7 no longer requires this post-processing for assets. The problem is that the 0.6 assets already had this process done to them and cannot be reversed. With the originals being lost someone had to recreate them all. Oy said on the forums one day that 0.7 could not be released without this being done so I volunteered to redraw all the assets. We are working now to finalize these assets.

Clearly 0.7 was shipped before everything was done to take care of some security issues so it still uses 0.6 assets. To see what I mean go into a map that has a Teehouse and look for a second at how horrible the curves are. This is due to the way things were done. Actually, there was an issue about the sun not looking good which is probably due to the same thing.

If you don't mind I would like to use your hearts and shield icons for the new assets as they are more teeish than the old ones.

@Zatline
Copy link
Member

Zatline commented Oct 31, 2018

@android272 it's beocuse the dilate and borderfix thing were applied on the bitmaps back then yes
now since those ain't needed anymore sure all bitmaps are flawed and had to be updated I totally get that but we can easily do it by just rendering a fresh bitmap out of the original svg, I'll take care of that, or you can since I'll grand you access shortly but we will not use your remakes!!
I went trough the folders that you have linked in the tw forum sections and it didn't took long for me to spot flaws in shape in color and shading there is lot of inconsistancy there, can't allow them after all the carefull work Landil, Crisis and me have put into creating and re-creating them the first time, I'm really sorry for that, but I'll literally go nuts if our work get's replaced with a less quality remake, no offense.

You have some incredible potential I'd like you to focus on an actual upcoming theme and help me with all gfx stuff since I'm like the last guy left of the old group, in return I help you refine your teestyle the way Landil helped me .. this has gone offtopic 🐤

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 31, 2018

The remade graphics need a lot of testing but I believe there were some improvements too. I wouldn't be so quick to discard them. Maybe it would be nice to look into them more carefully, collaborate and merge what can be?

@Zatline
Copy link
Member

Zatline commented Oct 31, 2018

@Dune-jr sure I'm absolutely open to review all of android's work in detail with him once we exchanged details and check what could be usefull what not and why not etcetera.

@Zatline
Copy link
Member

Zatline commented Oct 31, 2018

making it upfront:

The feedback relating the changed health and armor icons has been extremly posetiv so they change with 0.7.1 thank you! That will automaticaly fix the issue with the old ones.
The totally black icons will get trancparant again like seen in @Sonix- mockup and the shield will remain yellow or perhaps change to grey we will see, white flag will get removed but not ruled out.
@oy you can close this issue!

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 31, 2018

Well, the issue should only be closed when it is fixed imo. Please include the changes first.

@Sonix-
Copy link
Member

Sonix- commented Oct 31, 2018

Yeah leave it open until you make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants