Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compiling using visual studio 2013 by renaming the round function #1170

Merged
merged 1 commit into from Feb 9, 2014

Conversation

SushiTee
Copy link
Contributor

@SushiTee SushiTee commented Dec 9, 2013

just a simple fix to be able to compile using vs 12

@TimToast
Copy link

TimToast commented Jan 2, 2014

i made a little tool, to fix this fast and simple with a backup function in visual basic
http://bttt.de/files/tw_src_patcher.rar

have fun

@heinrich5991
Copy link
Contributor

round_to_int doesn't fit to the rest fo the file, what about roundf or similar?

@TimToast
Copy link

TimToast commented Jan 2, 2014

i just used the function round, because in sushis commit it was made the same
-> it look like, that just the function round make problems ^.^

@SushiTee
Copy link
Contributor Author

SushiTee commented Jan 2, 2014

actually i tried to use a name which will definitely never be in some header from vs but the name may need some further discussion or another solution

@heinrich5991
Copy link
Contributor

OK, roundf doesn't seem like a good idea, it's defined as well as round in the C99 standard. http://en.cppreference.com/w/c/numeric/math/round

oy added a commit that referenced this pull request Feb 9, 2014
fixed compiling using visual studio 2013 by renaming the round function
@oy oy merged commit 19912be into teeworlds:master Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants