Remove insecure tempfile.mktemp #2677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinrich5991
requested changes
Jul 30, 2020
| @@ -54,7 +54,7 @@ def _finish(self, hfs, dmg): | |||
| def create(self, dmg, volume_name, directory, symlinks): | |||
| input_size = sum(os.stat(os.path.join(path, f)).st_size for path, dirs, files in os.walk(directory) for f in files) | |||
| output_size = max(input_size * 2, 1024**2) | |||
| hfs = tempfile.mktemp(prefix=dmg + '.', suffix='.hfs') | |||
| hfs = NamedTemporaryFile(prefix=dmg + '.', suffix='.hfs', delete=False) | |||
There was a problem hiding this comment.
That seems to have other semantics, mktemp does not create a file, NamedTemporaryFile does. This absolutely needs to be tested before merging.
This could perhaps be solved by doing the whole thing in a temporary directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by lgtm.com mentioned by @jxsl13 :)
tempfile.mktemp is deprecated since Python 2.3 and considered weak https://cwe.mitre.org/data/definitions/377.html
change is untested
Sadly I could not get all dependencies building (planetbeing/libdmg-hfsplus#14) and thus could not test this branch of code. If one has the binaries for hfsplus please test this.
As far as I understood this script should be run like this: