Hotfix CVE-2021-43518 #3018
Merged
Hotfix CVE-2021-43518 #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I'm confused, why wasn't this released? |
I guess because the proper fix it still a work in progress in #2931 |
|
I don't understand the point of a hotfix if it isn't meant to be released immediately while the proper fix is in progress. |
Safety for developers and others who build from source :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for CVE-2021-43518. Closes #2981.
Adding all the datafile validation (#2931) ended up being a rather large patch and it still needs some work. This hotfix just addresses the exploitable stack buffer overflow write.
Fixing the other issues individually would be pointless, as there are at least 50-100 more distinct maps that can crash the client or cause ASAN/UBSAN errors.