Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Dark mode, color offset #65

Closed
zhl111 opened this issue Aug 29, 2022 · 13 comments
Closed

[BUG]Dark mode, color offset #65

zhl111 opened this issue Aug 29, 2022 · 13 comments
Assignees
Labels
bug Something isn't working windows

Comments

@zhl111
Copy link

zhl111 commented Aug 29, 2022

image

@zhl111 zhl111 added the bug Something isn't working label Aug 29, 2022
@voidffu
Copy link

voidffu commented Sep 15, 2022

me too

@tefkah
Copy link
Owner

tefkah commented Sep 20, 2022

could you provide some more info, e.g. what your system is, which version of zotero/night you are using?

works fine for me on macos 13.0 / Night 4.16

@xiangyi-wang
Copy link

xiangyi-wang commented Sep 25, 2022

image
@tefkah Windows 10 21H2 19044.1706 / Night 4.16

@tefkah
Copy link
Owner

tefkah commented Sep 25, 2022

Thank you! Is this the case with all papers?

@xiangyi-wang
Copy link

Thank you! Is this the case with all papers?

Yes

@tefkah
Copy link
Owner

tefkah commented Nov 3, 2022

this seems to happen on windows, not macos, im still looking into this

@tefkah tefkah added the windows label Nov 3, 2022
@GritLs
Copy link

GritLs commented Nov 28, 2022

me too

@tefkah
Copy link
Owner

tefkah commented Nov 28, 2022

@GritLs are you also on windows?

@GritLs
Copy link

GritLs commented Nov 28, 2022 via email

@tefkah
Copy link
Owner

tefkah commented Nov 29, 2022

So I think I've narrowed it down somewhat to Windows' ClearType Rendering. I set up a VM and the color offset is very noticeable, apologies for not getting on this faster!

Here with ClearType turned off
image

Here with ClearType turned on
image

I'm not sure if there's anything I can do about this. It does seem to depend on the parameters of the filter, e.g. in black mode it's not noticeable at all.

image

@tefkah
Copy link
Owner

tefkah commented Nov 29, 2022

I say that, but after a lot of manual fucking with the filter... no bleed WITH cleartype!
image

The important part seems to be the saturation filter, if that's too high (over 400%) ClearType becomes very visible.

This should be fixed in the next release!

@tefkah
Copy link
Owner

tefkah commented Nov 29, 2022

Hmmm looking at it on my Mac again there is still some bleed, but it's at least a lot less!

@tefkah
Copy link
Owner

tefkah commented Nov 29, 2022

image
Think i managed to make it even less noticeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

No branches or pull requests

5 participants