Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use the event writer to build element trees #1032

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented May 7, 2024

📒 Description

The first impl was a disaster, because I thought the treebuilders from lxml and native python, could deal with sax events out of the box, but that wasn't the case. I had to reuse the EventContent handler we use for normal xml serialization in order to get a consistent output.

Unfortunately because of limitations with the python's ElementTree with namespaces and prefixes, the TreeSerializer only works with lxml.

Resolves #1028

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (eab6bb7) to head (510b2b9).

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1032      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          117      115       -2     
  Lines         9272     9264       -8     
  Branches      2194     2190       -4     
===========================================
- Hits          9272     9261      -11     
- Misses           0        2       +2     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit 3885f17 into main May 7, 2024
13 of 15 checks passed
@tefra tefra deleted the tree-serializer-v3 branch May 7, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite tree serializers to utilize the existing event writers
1 participant