Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run Ruff on package directories rather than files #1049

Merged
merged 1 commit into from
May 30, 2024

Conversation

SrirachaHorse
Copy link
Contributor

📒 Description

Run Ruff on package directories rather than individual files, to avoid large schema sets exceeding the character limits when on Windows.

Resolves #1048

🔗 What I've Done

Updates the DataclassGenerator.render() method to collect package directories rather than individual files, to be passed to the ruff_code() method.

Also adds a warning to the Configuration page of the documentation to indicate that Ruff will be run on any file in the package directory.

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cbec5fa) to head (4322332).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1049   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9223      9222    -1     
  Branches      2178      2178           
=========================================
- Hits          9223      9222    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SrirachaHorse SrirachaHorse marked this pull request as ready for review May 30, 2024 06:24
Copy link
Owner

@tefra tefra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@tefra tefra merged commit 791a98e into tefra:main May 30, 2024
15 checks passed
@SrirachaHorse SrirachaHorse deleted the fix-1048 branch May 31, 2024 00:55
skinkie pushed a commit to skinkie/xsdata that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calls to Ruff format/check fail on Windows for large document sets
2 participants