Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: Serializer config pretty_print/pretty_print_identation #942

Merged
merged 1 commit into from Feb 16, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Feb 16, 2024

馃搾 Description

We have two config settings for indentation, pretty_print and pretty_print_indent. The first is a bool flag and the other is the spaces to indent. The behavior is not consistent between xml/json.

Let's merge them!

Resolves #xxxx

馃敆 What I've Done

  • Deprecate pretty_print and pretty_print_indent and replace them with the new one indent
  • Maintain compatibility in order to not freak out users but raise some warnings

馃挰 Comments

A place to write any comments to the reviewer.

馃洬 Checklist

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit 2b01dbf into main Feb 16, 2024
7 of 13 checks passed
@tefra tefra deleted the unify-identantion branch February 16, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant