Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid flattening elements #945

Merged
merged 2 commits into from Feb 18, 2024
Merged

Avoid flattening elements #945

merged 2 commits into from Feb 18, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Feb 18, 2024

📒 Description

All xs:schema elements are classes everything else is either noise or class properties

That naive assumption is what started this project almost 5 years ago. Since then I am trying to get to that milestone by only generating root level elements and complex types, but in order to get there I had to solve the xml schemas puzzle, sometimes making compromises in order for certain things to work. That's why in some occasions I had to be aggressive with the flattening process and to introduce the filtering strategies.

Every year I tried to enable this feature and every year I had so many issues. Something was missing... I can't put my finger on what exactly but it seems this year we will make it. The w3c tests pass, the samples repo build passes.

Resolves #xxxx

🔗 What I've Done

  • Finally adhere to my naive assumption and only generate the root elements and complex types!

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarcloud bot commented Feb 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afa5368) 99.97% compared to head (f89c292) 99.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files         109      109              
  Lines        8791     8762      -29     
  Branches     2084     2075       -9     
==========================================
- Hits         8789     8760      -29     
  Misses          1        1              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit cf3aa92 into main Feb 18, 2024
13 of 15 checks passed
@tefra tefra deleted the avoid-flattening-elements branch February 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant