feat: Disambiguate choices #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tefra
force-pushed
the
ambiguous-choices
branch
from
82dc7d7
to
f3f1ca3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 109 110 +1
Lines 8761 8899 +138
Branches 2075 2116 +41
========================================
+ Hits 8759 8897 +138
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
tefra
force-pushed
the
ambiguous-choices
branch
from
f3f1ca3
to
c81d56a
Compare
tefra
force-pushed
the
ambiguous-choices
branch
from
c81d56a
to
3eebc37
Compare
tefra
force-pushed
the
ambiguous-choices
branch
2 times, most recently
from
650120c
to
c4741d3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Compound fields might contain elements with the same type, this makes it impossible to detect the the real qname during serialization. Currently we detect these cases and wrap values in a
DerivedElementwrapper.Let's see if it's possible to avoid the
DerivedElementby generating dataclasses with dedicated name/namespaceResolves #920
🔗 What I've Done
💬 Comments
🛫 Checklist