Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure original name case returns valid python identifiers #950

Merged
merged 1 commit into from Feb 19, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Feb 19, 2024

📒 Description

Write a brief description of your PR.

Resolves #948

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4b6a58) 99.97% compared to head (ebfc0a7) 99.97%.

❗ Current head ebfc0a7 differs from pull request most recent head e33113e. Consider uploading reports for the commit e33113e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files         109      109              
  Lines        8763     8761       -2     
  Branches     2075     2075              
==========================================
- Hits         8761     8759       -2     
  Misses          1        1              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit 853bb04 into main Feb 19, 2024
11 of 13 checks passed
@tefra tefra deleted the fix-948 branch February 19, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v24 and #881 break private package names
1 participant