fix: All non-native types must have a reference id #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the class validator to catch these cases otherwise trying to troubleshoot issues becomes impossible.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 110 110
Lines 8904 8920 +16
Branches 2116 2122 +6
=======================================
+ Hits 8902 8918 +16
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Before the code analyzer exits, it runs some additional checks just to make sure there are no cross-references anywhere because they are evil.
We also need to make sure there are no attr types to user types without any references....
Because I haven't updated these checks for so long, debugging future features was a pain in the a$$
Resolves #xxxx
🔗 What I've Done
💬 Comments
🛫 Checklist