Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect circular references more accurately #969

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Mar 9, 2024

📒 Description

The circular reference detection produces way to many false positives and in some cases causes invalid classes with missing imports. The original code was smart but it's time to rewrite it.

Resolves #xxxx

🔗 What I've Done

I am so proud of this :)

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (57e6f92) to head (3190828).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         110      111    +1     
  Lines        8952     8965   +13     
  Branches     2133     2134    +1     
=======================================
+ Hits         8950     8963   +13     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit b8a2abc into main Mar 9, 2024
14 checks passed
@tefra tefra deleted the circular-dependencies branch March 9, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant