Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add src code excerpt on ruff errors #996

Merged
merged 1 commit into from Mar 24, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Mar 24, 2024

📒 Description

Really helpful to see exactly what the error was, when we update the generator

Error: Ruff failed
details: Failed to parse netex/models/entity_in_version_structure.py:378:58: Unexpected token ']'
source:

   class AlternativeText(AlternativeTextVersionedChildStructure):
       class Meta:
           namespace = "http://www.netex.org.uk/netex"

--->    validity_conditions_or_valid_between: Optional[Union[]] = field(
           init=False,
           metadata={
               "type": "Ignore",

Resolves #xxxx

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (cd65e54) to head (0ab7520).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         117      117           
  Lines        9140     9156   +16     
  Branches     2172     2175    +3     
=======================================
+ Hits         9135     9151   +16     
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit a15c3e7 into main Mar 24, 2024
13 of 14 checks passed
@tefra tefra deleted the ruff-errors-details branch March 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant