Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate type hints for compound fields with token elements #997

Merged
merged 1 commit into from Mar 24, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Mar 24, 2024

📒 Description

We recently added proper typehints on compound fields, but it fails when one of the choices has a tokens element. This pr moves the generation of the typehint to the filters instead of calculating the types in the handlers.

Resolves #895

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@tefra
Copy link
Owner Author

tefra commented Mar 24, 2024

We are in desperate need to rewrite the type hints analyze process, it's sooo bad

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (a15c3e7) to head (4a06e4a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         117      117           
  Lines        9156     9169   +13     
  Branches     2175     2179    +4     
=======================================
+ Hits         9151     9164   +13     
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit ff01d9b into main Mar 24, 2024
14 checks passed
@tefra tefra deleted the fix-compound-field-types branch March 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotations for compound fields don't address token elements
1 participant