Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit: Resolve prohibited attrs override issues #998

Merged
merged 2 commits into from Mar 25, 2024
Merged

fit: Resolve prohibited attrs override issues #998

merged 2 commits into from Mar 25, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Mar 25, 2024

📒 Description

  • We supported converting attrs to list when parent was a list but not the child attr, we also need to support the opposite
  • In both cases we need to protect against updating prohibited attrs

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (ff01d9b) to head (ffe2bd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         117      117           
  Lines        9169     9174    +5     
  Branches     2179     2180    +1     
=======================================
+ Hits         9164     9169    +5     
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit 96d2085 into main Mar 25, 2024
14 checks passed
@tefra tefra deleted the sdmx-ml-suite branch March 25, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant