Feature/initial draft #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2019 15:48
Vitormdias
suggested changes
Apr 10, 2019
dist/index.d.ts
Outdated
| @@ -1 +1,3 @@ | |||
| export declare function testLib(): string; | |||
| import { plug } from "./plug"; | |||
There was a problem hiding this comment.
Tentar não usar a pasta dist e fazer isso no build
jest.config.js
Outdated
| "js", | ||
| "jsx", | ||
| "json", | ||
| "node" |
There was a problem hiding this comment.
remover extensão desnecessária
lib/aux/aux-code.tsx
Outdated
| @@ -0,0 +1,67 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
renomear aux para example
| import { TStream, ILifecycle, IPlugState } from './interfaces/plug'; | ||
|
|
||
|
|
||
| export const plug = <T extends {}>(stream: TStream, lifecycleHooks: Partial<ILifecycle> = {}, |
There was a problem hiding this comment.
futuramente podemos usar Hooks aqui
| @@ -35,5 +35,22 @@ | |||
| "istanbul": "^0.4.5", | |||
| "mocha": "^6.0.2", | |||
| "typescript": "^3.3.4000" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/core": "^7.4.0", | |||
There was a problem hiding this comment.
separar dependencies e devDependencies
added 2 commits
April 10, 2019 16:55
Vitormdias
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.