Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saunter breaking when used with NSwag > 13.16.1 #156

Closed
cvietor opened this issue Jan 12, 2023 · 1 comment
Closed

Saunter breaking when used with NSwag > 13.16.1 #156

cvietor opened this issue Jan 12, 2023 · 1 comment

Comments

@cvietor
Copy link

cvietor commented Jan 12, 2023

When using Saunter (0.11.0) along with a NSwag version greater than 13.16.1, document generation is broken, propably because of updates in NSwag regarding Namotion.Reflection, used by NJsonSchema.
I suspect this NSwag release to be the interfering issue for saunter:
https://github.com/RicoSuter/NSwag/releases/tag/v13.17.0

Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
      An unhandled exception has occurred while executing the request.
      System.MissingMethodException: Method not found: 'System.String Namotion.Reflection.XmlDocsExtensions.GetXmlDocsRemarks(System.Reflection.MemberInfo, Boolean)'.
         at Saunter.Generation.DocumentGenerator.GenerateOperationFromMethod(MethodInfo method, AsyncApiSchemaResolver schemaResolver, OperationType operationType, AsyncApiOptions options, JsonSchemaGenerator jsonSchemaGenerator, IServiceProvider
serviceProvider)
         at Saunter.Generation.DocumentGenerator.GenerateChannelsFromMethods(IEnumerable`1 asyncApiTypes, AsyncApiSchemaResolver schemaResolver, AsyncApiOptions options, JsonSchemaGenerator jsonSchemaGenerator, IServiceProvider serviceProvider)
         at Saunter.Generation.DocumentGenerator.GenerateChannels(TypeInfo[] asyncApiTypes, AsyncApiSchemaResolver schemaResolver, AsyncApiOptions options, JsonSchemaGenerator jsonSchemaGenerator, IServiceProvider serviceProvider)
         at Saunter.Generation.DocumentGenerator.GenerateDocument(TypeInfo[] asyncApiTypes, AsyncApiOptions options, AsyncApiDocument prototype, IServiceProvider serviceProvider)
         at Saunter.Generation.AsyncApiDocumentProvider.GetDocument(AsyncApiOptions options, AsyncApiDocument prototype)
         at Saunter.AsyncApiMiddleware.Invoke(HttpContext context)
         at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
         at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

I tested and can verify that this issue will be fixed after integrating #154

@cvietor cvietor changed the title Saunter breaking with used along NSwag > 13.16.1 Saunter breaking when used with NSwag > 13.16.1 Feb 5, 2023
@m-wild
Copy link
Collaborator

m-wild commented Jun 15, 2023

This is live in v0.12.0

@m-wild m-wild closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants