servlet #219
Open
servlet #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhangeldim
reviewed
Jan 8, 2018
|
|
||
| private void connect() { | ||
| String baseName = null; | ||
| for (int i = 0; i < 3; i++){ |
There was a problem hiding this comment.
- Лучше вынести в отдельный метод логику определения шарда
- switch-case внутри for - выглядит странно
| append("track17?"). //db name | ||
| append("user=track_student&"). //login | ||
| append("password=7EsH.H6x"); //password | ||
| connectionsMap.put(new Integer(i), DriverManager.getConnection(url.toString())); |
| } | ||
|
|
||
| private Connection returnDbconnection(String username) throws IllegalArgumentException{ | ||
| char firstLetter = username.toLowerCase().toCharArray()[0]; |
| public long store(Message msg) { | ||
| try { | ||
| Connection connection = returnDbconnection(msg.ownerLogin); | ||
| PreparedStatement statement = connection.prepareStatement |
There was a problem hiding this comment.
statement и resultSet нужно закрывать в finally блоке. Касается запросов во всем коде
|
|
||
|
|
||
| }catch (SQLException | IllegalArgumentException e) { | ||
| if (e instanceof IllegalArgumentException) { |
There was a problem hiding this comment.
Не надо так. Сделайте 2 отдельных catch блока
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { | ||
| Map<String, String[]> params = req.getParameterMap(); | ||
|
|
||
| if (params.containsKey("limit")){ |
| Map<String, String[]> params = req.getParameterMap(); | ||
|
|
||
| if (params.containsKey("limit")){ | ||
| ConversationService conv = new ConversationService(); |
There was a problem hiding this comment.
Надо создать внутри конструктора, а не при каждом запросе
|
|
||
| if (params.containsKey("username") && params.containsKey("text")) { | ||
| if (!req.getParameter("username").equals("")) { | ||
| ConversationService conv = new ConversationService(); |
There was a problem hiding this comment.
тоже создать в конструкторе сервлета
| Map<String, String[]> params = req.getParameterMap(); | ||
|
|
||
| if (params.containsKey("limit") && params.containsKey("username")){ | ||
| ConversationService conv = new ConversationService(); |
|
|
||
| List<Message> msgUserHistory = conv.getByUser(req.getParameter("username"), Long.parseLong(req.getParameter("limit"))); | ||
| req.setAttribute("msgList", msgUserHistory); | ||
| req.getRequestDispatcher("/history.jsp").forward(req, resp); |
There was a problem hiding this comment.
Один и тот же .jsp для двух сервлетов - это не очень хорошая практика. Лучше разнести их изначально
arhangeldim
reviewed
Jan 30, 2018
| import java.util.Map; | ||
|
|
||
| public class UserHistory extends HttpServlet { | ||
| private String[] param = {"limit", "username"}; |
There was a problem hiding this comment.
Ключи параметров лучше вынести в константы
| @@ -0,0 +1,38 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Ну как так? В конце семестра пулл-реквест снова забит бинарниками и левыми файлами? =(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.