Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IV/CP Logic #35

Merged
merged 21 commits into from
Jul 24, 2016
Merged

Fix IV/CP Logic #35

merged 21 commits into from
Jul 24, 2016

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jul 24, 2016

Changed or to and.

@OpenPoGo/maintainers

meyer9 added 10 commits July 23, 2016 22:10
Better formatting (single line fixes, single quote-> double quote)
Better api accessors (use modern python)
Use modern python instead of try-catch loops
Add more helper functions
Clarify variable names
Use modern python instead of try-catch loops
Add more helper functions
Clarify variable names
@meyer9
Copy link
Contributor Author

meyer9 commented Jul 24, 2016

do not accept this until #29 is approved.

@wchill
Copy link
Contributor

wchill commented Jul 24, 2016

👍 pending approval of #29.

Approved with PullApprove

@wchill
Copy link
Contributor

wchill commented Jul 24, 2016

👍

Approved with PullApprove

@Gary-BOT
Copy link
Contributor

Gary-BOT commented Jul 24, 2016

👍

Approved with PullApprove

@Gary-BOT Gary-BOT merged commit b4c458c into master Jul 24, 2016
@wchill wchill mentioned this pull request Jul 24, 2016
@MaxLeiter MaxLeiter deleted the bugfix/iv-cp-logic branch July 24, 2016 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants