[WIP] Changing the Bot to Event-Based #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create EventManager / IEventHandler - Moved out a bunch of the cell things into handlers
| from cell_workers.utils import distance | ||
| from events import IEventHandler | ||
|
|
||
| class CachablePokemonHandler(IEventHandler): |
There was a problem hiding this comment.
ty - I was thinking of cache. Note, this is still heavily WIP - I just wanted to add some progress
|
Mind providing a list of what's left to be worked on so other people can contribute? Awesome work so far :) |
|
@TheSavior can you join our slack and maybe discuss a bit about this? |
|
Sorry, didn't realize this was a different bot. I have no feelings about the approach you guys take, but I strongly don't think this is the right approach for the upstream bot. I have laid out the concerns that I have about it here: PokemonGoF/PokemonGo-Bot#706 The approach we want to go in to enable extensibility and configuration is using behavior trees PokemonGoF/PokemonGo-Bot#142 |
|
#67 - closed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Still WIP
Short Description: Complete change of PokemonGoBot to utilize dynamically loaded events.
Changes:
TODO
@OpenPoGo/maintainers