Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for mailgun 2.3 #40

Merged
merged 6 commits into from
May 29, 2017
Merged

Prepare for mailgun 2.3 #40

merged 6 commits into from
May 29, 2017

Conversation

Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Apr 8, 2017

We want to support the new mailgun API. There are still some issue here. But this is a first draft.

@Nyholm
Copy link
Collaborator Author

Nyholm commented Apr 10, 2017

I've solved the issues. This PR is ready for a review. It is blocked by mailgun/mailgun-php#341

@Nyholm Nyholm changed the title [WIP] Prepare for mailgun 2.2 Prepare for mailgun 2.3 Apr 10, 2017
@Nyholm Nyholm added this to the Release 0.4 milestone Apr 14, 2017
@codecov-io
Copy link

codecov-io commented Apr 14, 2017

Codecov Report

Merging #40 into master will decrease coverage by 0.04%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   88.11%   88.07%   -0.05%     
==========================================
  Files           3        3              
  Lines         101      109       +8     
==========================================
+ Hits           89       96       +7     
- Misses         12       13       +1
Impacted Files Coverage Δ
Service/MailgunTransport.php 84.5% <66.66%> (+1.17%) ⬆️
...encyInjection/cspooSwiftmailerMailgunExtension.php 92.3% <83.33%> (-7.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21efc86...19f5518. Read the comment docs.

@Nyholm Nyholm merged commit 28683a4 into master May 29, 2017
@Nyholm Nyholm deleted the mailgun22 branch May 29, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants