Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] show burn action in history? (+bug) #69

Closed
stumats opened this issue Apr 10, 2022 · 4 comments · Fixed by #108
Closed

[feat] show burn action in history? (+bug) #69

stumats opened this issue Apr 10, 2022 · 4 comments · Fixed by #108
Labels
🐛 bug Something isn't working 🐣 good first issue Good for newcomers

Comments

@stumats
Copy link

stumats commented Apr 10, 2022

Describe the bug
Seems that in the new UI, history doesn't show burns.
This then appears to cause swap numbers to vary, and the initial mint seems to be incorrect.

To Reproduce EXAMPLE
Steps to reproduce the behavior:

  1. Go to '...' 715249

  2. Click on history

  3. See issue- it says minted 10 / swapped 20

Expected behaviour
I'm assuming that 20 were minted, 20 were swapped and then 10 were burnt.
expect to see either that 10 were burned (and initial mint was 20) , or minted 10 / swapped 10 (if none were burned)

This is the only example I have evidence for, but have noticed inconsistencies in History listings before, that seem to imply burning may have happened.

@melMass melMass added 🐣 good first issue Good for newcomers 🐛 bug Something isn't working labels Apr 15, 2022
@melMass melMass changed the title history doesn't show burn actions and instead changes the initial mint number if editions are burned Show burn action in history? (+bug) Apr 15, 2022
@Zir0h
Copy link
Contributor

Zir0h commented Apr 16, 2022

Do we need an indexer update for this? In on_transfer the only thing we keep is the amount of objects that get burned/transferred, no timestamp or ophash.

Correct me if I'm wrong but I think at the moment we can only show the total amount of burned tokens?

@melMass
Copy link
Member

melMass commented Apr 17, 2022

Correct me if I'm wrong but I think at the moment we can only show the total amount of burned tokens?

I don't know how it's stored in the indexer but we could always use tzkt for these only

@stumats
Copy link
Author

stumats commented Jun 7, 2022

maybe... not sure what that looks like in practise :-) Can you bring in date too? (oh - date is there already I think)

@melMass melMass linked a pull request Jun 9, 2022 that will close this issue
@melMass melMass changed the title Show burn action in history? (+bug) [feat] show burn action in history? (+bug) Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🐣 good first issue Good for newcomers
Projects
3 participants