Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake #11 - Builder pattern part #27

Closed
ndjordjevic opened this issue May 5, 2023 · 1 comment
Closed

Mistake #11 - Builder pattern part #27

ndjordjevic opened this issue May 5, 2023 · 1 comment
Labels
erratum Erratum

Comments

@ndjordjevic
Copy link

Func NewServer is defined as:
func NewServer(addr string, config Config) (*http.Server, error)
... you can't pass nil as a config param right?
You said this:

However, we still need to pass a
config struct that can be empty if a client wants to use the default configuration:
server, err := httplib.NewServer("localhost", nil)

@ndjordjevic ndjordjevic added the erratum Erratum label May 5, 2023
@teivah
Copy link
Owner

teivah commented Jun 6, 2023

Thanks, it'll be fixed in the next version 🙏

@teivah teivah closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erratum Erratum
Projects
None yet
Development

No branches or pull requests

2 participants